svn commit: r1857090 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java

[mthl]

Author: mthl
Date: Sun Apr  7 23:12:13 2019
New Revision: 1857090

URL: http://svn.apache.org/viewvc?rev=1857090&view=rev
Log:
Improved: Remove ‘CreateTableCallable’ private class (OFBIZ-10912)

This class was never instantiated locally.  Since this was a private
class it is better to remove it.

Modified:
    
ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java

Modified: 
ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java?rev=1857090&r1=1857089&r2=1857090&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
 Sun Apr  7 23:12:13 2019
@@ -217,7 +217,7 @@ public class DatabaseUtil {
             Debug.logError(message, module);
             return;
         }
-        List<Future<CreateTableCallable>> tableFutures = new 
LinkedList<Future<CreateTableCallable>>();
+
         for (ModelEntity entity: modelEntityList) {
             curEnt++;
 
@@ -400,9 +400,6 @@ public class DatabaseUtil {
                 }
             }
         }
-        for (CreateTableCallable tableCallable: 
ExecutionPool.getAllFutures(tableFutures)) {
-            tableCallable.updateData(messages, entitiesAdded);
-        }
 
         timer.timerString("After Individual Table/Column Check");
 
@@ -1482,47 +1479,6 @@ public class DatabaseUtil {
         return indexInfo;
     }
 
-    private class CreateTableCallable implements Callable<CreateTableCallable> 
{
-        private final ModelEntity entity;
-        private final Map<String, ModelEntity> modelEntities;
-        private final String tableName;
-        private String message;
-        private boolean success;
-
-        protected CreateTableCallable(ModelEntity entity, Map<String, 
ModelEntity> modelEntities, String tableName) {
-            this.entity = entity;
-            this.modelEntities = modelEntities;
-            this.tableName = tableName;
-        }
-
-        public CreateTableCallable call() throws Exception {
-            String errMsg = createTable(entity, modelEntities, false);
-            if (UtilValidate.isNotEmpty(errMsg)) {
-                this.success = false;
-                this.message = "Could not create table [" + tableName + "]: " 
+ errMsg;
-                Debug.logError(this.message, module);
-            } else {
-                this.success = true;
-                this.message = "Created table [" + tableName + "]";
-                Debug.logImportant(this.message, module);
-            }
-            return this;
-        }
-
-        protected void updateData(Collection<String> messages, 
List<ModelEntity> entitiesAdded) {
-            if (this.success) {
-                entitiesAdded.add(entity);
-                if (messages != null) {
-                    messages.add(this.message);
-                }
-            } else {
-                if (messages != null) {
-                    messages.add(this.message);
-                }
-            }
-        }
-    }
-
     private abstract class AbstractCountingCallable implements 
Callable<AbstractCountingCallable> {
         protected final ModelEntity entity;
         protected final Map<String, ModelEntity> modelEntities;