Author: jleroux
Date: Tue Oct 30 09:37:08 2018
New Revision: 1845208
URL: http://svn.apache.org/viewvc?rev=1845208&view=rev
Log:
Improved: Remove unused ‘RequestHandler::doRequest’ method
(OFBIZ-10452)
The RequestHandler#doRequest is only a wrapper for an overload.
Since it is not used anywhere in the framework, just remove it.
jleroux: jaz (Andrew Zeneski) added it as a "convenience". I see no problems
removing it
Thanks: Mathieu Lirzin
Modified:
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
Modified:
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java?rev=1845208&r1=1845207&r2=1845208&view=diff
==============================================================================
---
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
(original)
+++
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
Tue Oct 30 09:37:08 2018
@@ -229,13 +229,6 @@ public class RequestHandler {
}
}
- public void doRequest(HttpServletRequest request, HttpServletResponse
response, String requestUri) throws RequestHandlerException,
RequestHandlerExceptionAllowExternalRequests {
- HttpSession session = request.getSession();
- Delegator delegator = (Delegator) request.getAttribute("delegator");
- GenericValue userLogin = (GenericValue)
session.getAttribute("userLogin");
- doRequest(request, response, requestUri, userLogin, delegator);
- }
-
public void doRequest(HttpServletRequest request, HttpServletResponse
response, String chain,
GenericValue userLogin, Delegator delegator) throws
RequestHandlerException, RequestHandlerExceptionAllowExternalRequests {
