TimJTi commented on code in PR #2178: URL: https://github.com/apache/nuttx-apps/pull/2178#discussion_r1385184850
########## examples/settings/settings_main.c: ########## @@ -0,0 +1,276 @@ +/**************************************************************************** + * apps/examples/settings/settings_main.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdio.h> +#include <sys/stat.h> +#include <fcntl.h> +#include <errno.h> +#include <sys/mount.h> + +#include "system/settings.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/**************************************************************************** + * Private Types + ****************************************************************************/ + +/**************************************************************************** + * Private Function Prototypes + ****************************************************************************/ + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/**************************************************************************** + * settings_main + ****************************************************************************/ + +int main(int argc, FAR char *argv[]) +{ + int ret; + int fd; + enum settings_type_e stype; + char path[50]; + char *teststr = ""; + int testval = 0x5aa5; + char readstr[CONFIG_SETTINGS_VALUE_SIZE]; + enum storage_type_e storage_type = STORAGE_BINARY; + bool flag_present = false; + struct stat sbuf; + + ASSERT(0); + if ((argc < 1) || *argv[1] == 0 || *(argv[1] + 1) == 0) + { + goto print_help; + } + + if (*argv[1] == '-') + { + flag_present = true; + if (*(argv[1] + 1) == 'b') + { + storage_type = STORAGE_BINARY; + } + else if (*(argv[1] + 1) == 't') + { + storage_type = STORAGE_TEXT; + } + else + { + goto print_help; + } + } + + if (flag_present && argc < 2) + { + goto print_help; + } + +#ifdef CONFIG_EXAMPLES_SETTINGS_USE_TMPFS +# ifndef CONFIG_FS_TMPFS +# error TMPFS must be enabled +# endif +# ifndef CONFIG_LIBC_TMPDIR +# error LIBC_TMPDIR must be defined +# endif + if (stat(CONFIG_LIBC_TMPDIR, &sbuf)) + { + ret = nx_mount(NULL, CONFIG_LIBC_TMPDIR, "tmpfs", 0, NULL); + if (ret < 0) + { + printf("ERROR: Failed to mount tmpfs at %s: %d\n", + CONFIG_LIBC_TMPDIR, ret); + goto end; Review Comment: So, it is the "return OK" at the end of the app that is wrong. That should be `return ret` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
