pkarashchenko commented on code in PR #2168: URL: https://github.com/apache/nuttx-apps/pull/2168#discussion_r1375911994
########## benchmarks/spinlock_bench/spinlock_bench.c: ########## @@ -0,0 +1,89 @@ +/**************************************************************************** + * apps/benchmarks/spinlock_bench/spinlock_bench.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdio.h> +#include <assert.h> +#include <errno.h> +#include <nuttx/spinlock.h> +#include <time.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define TEST_NUM CONFIG_SPINLOCK_MULTITHREAD +#define THREAD_NUM CONFIG_SPINLOCK_MULTITHREAD + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static spinlock_t lock = SP_UNLOCKED; + +static pthread_t g_thread[THREAD_NUM]; + +static int g_result = 0; + +static FAR void thread_spinlock(FAR void *parameter) +{ + for (int i = 0; i < TEST_NUM; i++) + { + spin_lock(&lock); + g_result++; + spin_unlock(&lock); + } +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +void spinlock_bench_main(void) +{ + int status; + g_result = 0; + + clock_t start = perf_gettime(); + for (int i = 0; i < THREAD_NUM; ++i) Review Comment: ```suggestion for (i = 0; i < THREAD_NUM; ++i) ``` ########## benchmarks/spinlock_bench/spinlock_bench.c: ########## @@ -0,0 +1,89 @@ +/**************************************************************************** + * apps/benchmarks/spinlock_bench/spinlock_bench.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdio.h> +#include <assert.h> +#include <errno.h> +#include <nuttx/spinlock.h> +#include <time.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define TEST_NUM CONFIG_SPINLOCK_MULTITHREAD +#define THREAD_NUM CONFIG_SPINLOCK_MULTITHREAD + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static spinlock_t lock = SP_UNLOCKED; + +static pthread_t g_thread[THREAD_NUM]; + +static int g_result = 0; + +static FAR void thread_spinlock(FAR void *parameter) +{ + for (int i = 0; i < TEST_NUM; i++) + { + spin_lock(&lock); + g_result++; + spin_unlock(&lock); + } +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +void spinlock_bench_main(void) +{ + int status; + g_result = 0; + + clock_t start = perf_gettime(); + for (int i = 0; i < THREAD_NUM; ++i) + { + status = pthread_create(&g_thread[i], NULL, + (void *)thread_spinlock, &g_thread[i]); + if (status != 0) + { + printf("spinlock_test: ERROR pthread_create failed, status=%d\n", + status); Review Comment: ```suggestion printf("spinlock_test: ERROR pthread_create failed, status=%d\n", status); ``` ########## benchmarks/spinlock_bench/spinlock_bench.c: ########## @@ -0,0 +1,89 @@ +/**************************************************************************** + * apps/benchmarks/spinlock_bench/spinlock_bench.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdio.h> +#include <assert.h> +#include <errno.h> +#include <nuttx/spinlock.h> +#include <time.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define TEST_NUM CONFIG_SPINLOCK_MULTITHREAD +#define THREAD_NUM CONFIG_SPINLOCK_MULTITHREAD + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static spinlock_t lock = SP_UNLOCKED; + +static pthread_t g_thread[THREAD_NUM]; + +static int g_result = 0; + +static FAR void thread_spinlock(FAR void *parameter) +{ + for (int i = 0; i < TEST_NUM; i++) + { + spin_lock(&lock); + g_result++; + spin_unlock(&lock); + } +} + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +void spinlock_bench_main(void) +{ + int status; Review Comment: ```suggestion int status; int i; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
