duduita commented on PR #7541: URL: https://github.com/apache/nuttx/pull/7541#issuecomment-1773954646
@P1F and I are working on the suggested changes to merge this PR, but we have some questions @xiaoxiang781216: 1) In our implementation, we created our own functions, like `nflite_addrule`, `nflite_listall`, `nflite_flushall`, etc... to add/list/delete the rules in the table. However, after taking a look at the iptables NAT implementation, and your comments, it seems that we should use the `ioctl` or `ioctl-like` operations to do it, instead of using our own functions, am I right? I'm asking since we thought that we could just create some syscalls, to use our own functions, but I believe that we should use the `ioctl/ioctl-like` operations instead. 2) I thought that we wouldn't have many things to do before merging the packet filter to NuttX, but considering what I said above, it seems that we'll have to basically rewrite all our functions to use `ioctl-like` operations, such as `setsockopt`, `getsockopt`, etc... Am I right, or maybe I'm making the things more complicated than they are? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
