xiaoxiang781216 commented on code in PR #10602: URL: https://github.com/apache/nuttx/pull/10602#discussion_r1361805528
########## sched/tls/task_initinfo.c: ########## @@ -28,6 +28,8 @@ #include <nuttx/kmalloc.h> #include <nuttx/mutex.h> +#include <nuttx/lib/lib.h> Review Comment: Yes, forget it's inside kernel space, but kernel code can't reference libc function directly even th inclusion is added. The better fix should be that seek/fwrite/fread call lseek/_NX_WRITE/_NX_READ directly if the related callback is NULL. ########## sched/tls/task_initinfo.c: ########## @@ -28,6 +28,8 @@ #include <nuttx/kmalloc.h> #include <nuttx/mutex.h> +#include <nuttx/lib/lib.h> Review Comment: Yes, forget it's inside kernel space, but kernel code can't reference libc function directly even the inclusion is added. The better fix should be that seek/fwrite/fread call lseek/_NX_WRITE/_NX_READ directly if the related callback is NULL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
