qinwei2004 commented on PR #10655:
URL: https://github.com/apache/nuttx/pull/10655#issuecomment-1754485090

   > Hi @qinwei2004: Sorry there's a minor issue with macOS Build, it shows 
some `sed` messages:
   > 
   > ```
   > $ tools/configure.sh pinephone:nsh
   > $ make
   > sed: illegal option -- r
   > ```
   > 
   > [(See the Complete 
Log)](https://gist.github.com/lupyuen/1c3f1f1d71993609bed3b31767595beb#file-pinephone-release-log-L282-L690)
   > 
   > The build completes successfully, so the `sed` message is harmless. I 
traced the message to this change: 
[arch/arm64/src/Toolchain.defs](https://github.com/apache/nuttx/blob/master/arch/arm64/src/Toolchain.defs#L169)
   > 
   > ```
   > # Workaround for GCC-12.2 linker warning
   > ifeq ($(CONFIG_ARCH_TOOLCHAIN_GNU),y)
   >   ifeq ($(GCCVER),)
   >     export GCCVER := $(shell $(CC) --version | grep gcc | sed -r "s/.* 
([0-9]+\.[0-9]+).*/\1/" | cut -d'.' -f1)
   > ```
   > 
   > Which doesn't work as expected on macOS `sed`. Let me study the code above 
and see whether I can make it work on macOS and Linux `sed`. It might be 
similar to this fix: 
[e334786](https://github.com/apache/nuttx/commit/e334786f8124915e3ee2c56cca7ac08fbf0d9243).
 Thanks!
   > 
   > **Update:** I have submitted the PR: #10881
   
   @anchao , please check the issue and @lupyuen 's PR: #10881,thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to