acassis commented on code in PR #10861: URL: https://github.com/apache/nuttx/pull/10861#discussion_r1347774594
########## include/nuttx/spinlock.h: ########## @@ -286,6 +304,7 @@ void spin_unlock_wo_note(FAR volatile spinlock_t *lock); /* bool spin_islocked(FAR spinlock_t lock); */ #define spin_islocked(l) (*(l) == SP_LOCKED) +#define spin_is_locked(l) spin_islocked(l) Review Comment: @xiaoxiang781216 in this case isn't it better just replace spin_islocked() with spin_is_locket() ? It is confusing because now we have two functions with similar names that do same thing! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org