xiaoxiang781216 commented on code in PR #10681: URL: https://github.com/apache/nuttx/pull/10681#discussion_r1330429653
########## libs/libc/pthread/pthread_once.c: ########## @@ -73,15 +75,15 @@ int pthread_once(FAR pthread_once_t *once_control, /* Prohibit pre-emption while we test and set the once_control. */ - sched_lock(); + flags = enter_critical_section(); Review Comment: but it's dangerous to call user provided callback inside spinlock. mutex is better than spinlock if you really want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
