gregory-nutt commented on PR #10602: URL: https://github.com/apache/nuttx/pull/10602#issuecomment-1719510693
I personally think you are going down the wrong path with this ad hoc logic. This is very high risk because I don't think either of you are considering all of the issues and complexities. You apparently seem focused on avoiding a clean context switch (which I believe is the correct, clean, flexible solution). I believe we need to at least insist on a good test for this code to give people like me confidence. A good test would include: - All build modes: FLAT, PROTECTED, and KERNEL (we would need some testing help). - Assure that user code never executes in kernel mode in the PROTECTED build - Test with client and server in same task/process; Client and server in different tasks/processes and different address spaces (in KERNEL mde). If it could pass a pretty rigorous test then I would become a believer. That, I think is a requirement for merging. I am not a believer now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
