btashton commented on code in PR #10211:
URL: https://github.com/apache/nuttx/pull/10211#discussion_r1292889522


##########
crypto/Kconfig:
##########
@@ -50,28 +50,9 @@ config CRYPTO_CRYPTODEV_HARDWARE
        depends on CRYPTO_CRYPTODEV
        default n
 
-config CRYPTO_SW_AES
-       bool "Software AES library"
-       depends on ALLOW_BSD_COMPONENTS

Review Comment:
   I generally agree here to just let the linker deal with it, but if want to 
actually have this `ALLOW_BSD_COMPONENTS` flag we cannot merge this in. That 
said I don't think this flag provides much value and I don't think it guards 
all BSD code. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to