pkarashchenko commented on code in PR #10110:
URL: https://github.com/apache/nuttx/pull/10110#discussion_r1287011089
##########
arch/risc-v/src/esp32c3/esp32c3_libc_stubs.c:
##########
@@ -59,12 +60,12 @@ struct _reent;
int _close_r(struct _reent *r, int fd)
{
- return close(fd);
+ return nx_close(fd);
Review Comment:
If we are having separate kernel and apps then we need to have two variants
of stubs as we are not able to determine on runtime. To use `_NX_CLOSE`,
`lib_malloc`, `lib_free` etc. we will need to have 2 stubs structures and app
vs kernel to be liked with different variants (like we are having two variants
of libc: one for kernel and one for apps) and this will require the stubs code
to be compiled two times with different options. For now let me revert the
changes related to stubs until we have a better solution as this seems to be a
grey zone for me right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
