raiden00pl commented on code in PR #10070: URL: https://github.com/apache/nuttx/pull/10070#discussion_r1284034253
########## drivers/usbdev/composite.h: ########## @@ -95,7 +95,7 @@ # define COMPOSITE_REMOTEWAKEUP (0) #endif -#define NUM_DEVICES_TO_HANDLE (4) +#define NUM_DEVICES_TO_HANDLE (8) Review Comment: shouldn't we make `NUM_DEVICES_TO_HANDLE` configurable with Kconfig ? then we can reuse this value in the board initialization logic, like here https://github.com/apache/nuttx/blob/856526adee25cdb9987ff800767a71ec9059d1ea/boards/arm/stm32h7/nucleo-h743zi/src/stm32_composite.c#L178 which is now not possible as `NUM_DEVICES_TO_HANDLE` is not available outside `drivers/usbdev` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
