mu578 commented on code in PR #6433: URL: https://github.com/apache/nuttx/pull/6433#discussion_r1254897266
########## include/sys/syscall_lookup.h: ########## @@ -33,13 +33,13 @@ SYSCALL_LOOKUP(gettid, 0) SYSCALL_LOOKUP(getppid, 0) #endif -SYSCALL_LOOKUP(sched_getparam, 2) -SYSCALL_LOOKUP(sched_getscheduler, 1) +SYSCALL_LOOKUP(nxsched_get_param, 2) +SYSCALL_LOOKUP(nxsched_get_scheduler, 1) SYSCALL_LOOKUP(sched_lock, 0) Review Comment: yes I concur make syscalls private ; not forcibly by programming or compiler extension but by tagging like ```c #define __nx_private__ #define __nx_coreos__ #define __nx_panecake__ __nx_private__ ... nxsched_get_param (... ) __nx_coreos__ ... nxsched_get_param (... ) __nx_panecake__ ... nxsched_get_param (... ) me I would dream in any OS implementation __nx_posix_version__ ... sched_getparam (... ) ``` whatever the naming convention ; it is all about being explicit, and with an editor to be able to search them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
