robertalexa2000 commented on PR #9523: URL: https://github.com/apache/nuttx/pull/9523#issuecomment-1617373896
Hi @acassis, sorry for taking so long to reply. Coming back to this - I understand what you are saying, but in that case we would couple the framebuffer char device with the LCD char device. Essentially, in order to enable framebuffer support, we will need to enable CONFIG_LCD_DEV - and there is no need for that since the framebuffer char device and the LCD char device offer completely distinct APIs. Besides, I believe that this approach will still not work. If we were to call fb_register from inside common/, we would still end up in a stack overflow because fb_register itself calls board_lcd_initialize, which in turn would call fb_register again. I also took a look at other boards and they all initialize the frame buffer from <board>_bringup.c, so I believe if we were to remove board_lcd_initialize from fb_register we would solve the issue on esp32 but break the framebuffer support on other boards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
