pkarashchenko commented on code in PR #9654:
URL: https://github.com/apache/nuttx/pull/9654#discussion_r1247645570


##########
fs/nfs/Kconfig:
##########
@@ -13,6 +13,15 @@ config NFS
 
 #if NFS
 
+config NFS_DONT_BIND_TCP_SOCKET

Review Comment:
   ```suggestion
   config NFS_NO_BIND_TCP_SOCKET
   ```
   Not sure if this is better. I'm ok to keep existing name



##########
fs/nfs/Kconfig:
##########
@@ -13,6 +13,15 @@ config NFS
 
 #if NFS
 
+config NFS_DONT_BIND_TCP_SOCKET
+       bool "Do not bind TCP socket"
+       default n
+       depends on NFS

Review Comment:
   Do we need
   
   ```suggestion
        depends on TCP
   ```
   ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to