xiaoxiang781216 commented on code in PR #9528:
URL: https://github.com/apache/nuttx/pull/9528#discussion_r1228516350
##########
sched/group/group_join.c:
##########
@@ -208,9 +218,12 @@ int group_join(FAR struct pthread_tcb_s *tcb)
{
return ret;
}
+#else
+ flags = enter_critical_section();
Review Comment:
Yes, from our test for SMP:
spinlock >> critical section >> mutex/sem
and no SMP:
spinlock ~= critical section >> mutex/sem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
