davids5 commented on code in PR #8952:
URL: https://github.com/apache/nuttx/pull/8952#discussion_r1184660225
##########
boards/arm/stm32/stm32f4discovery/src/stm32_usbmsc.c:
##########
@@ -63,7 +63,7 @@ int board_usbmsc_initialize(int port)
*/
#ifndef CONFIG_NSH_BUILTIN_APPS
- return stm32_sdinitialize(CONFIG_SYSTEM_USBMSC_DEVMINOR1);
+ return stm32_mmcsd_initialize(2, CONFIG_SYSTEM_USBMSC_DEVMINOR1)
Review Comment:
```suggestion
return stm32_mmcsd_initialize(2, CONFIG_SYSTEM_USBMSC_DEVMINOR1);
```
##########
boards/arm/stm32h7/nucleo-h743zi/src/nucleo-h743zi.h:
##########
@@ -196,6 +196,16 @@
GPIO_OUTPUT_CLEAR | GPIO_PORTF | GPIO_PIN12)
#define GPIO_NRF24L01_IRQ (GPIO_INPUT | GPIO_FLOAT | GPIO_PORTD | GPIO_PIN15)
+/* MMC/SD
+ * CS - PD15 (D9)
+ * NCD - PF12 (D8)
+ */
+
+#define GPIO_MMCSD_CS (GPIO_OUTPUT | GPIO_PUSHPULL | GPIO_SPEED_50MHz | \
+ GPIO_OUTPUT_SET | GPIO_PORTD | GPIO_PIN15)
Review Comment:
```suggestion
GPIO_OUTPUT_SET | GPIO_PORTD | GPIO_PIN15)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
