tmedicci commented on PR #9150: URL: https://github.com/apache/nuttx/pull/9150#issuecomment-1531519907
> > > @tmedicci please add commit message explaining the change > > > > > > Hi @jerpelea , I didn't get what message should be updated. I updated the PR title (sorry, I forgot it). Besides it, do you think any commit needs to be improved? > > usually each commit has a message describing the change / things it fixes or enhancements. (including logs where applicable) The PR message is not displayed when someone uses git log to see the patches. Usually, I use the following pattern for commits: on 1st line, a general description, 2nd line (empty), 3rd (and others) a message describing the commit in detail. However, in this PR (and others), the 1st line describes the commits sufficiently, I think: ``` 2023-05-01 21:10 -0300 Tiago Medicci Serrano o [feature/add_rtptools] documentation: add references to RTP Tools' defconfigs 2023-03-08 22:15 -0300 Tiago Medicci Serrano o boards/esp32-lyrat/configs: add defconfig for RTP Tools 2023-02-24 12:04 -0300 Tiago Medicci Serrano o boards/sim/configs: add defconfig for RTP Tools ``` I couldn't think of any additional information that would fit the "detail" section of the message. I think it'd be just verbosity and repetition. Do you have any thoughts about it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
