gustavonihei commented on code in PR #9020: URL: https://github.com/apache/nuttx/pull/9020#discussion_r1169182997
########## arch/xtensa/src/esp32/esp32_serial.c: ########## @@ -639,16 +639,21 @@ static void esp32_dmasend(struct uart_dev_s *dev) { struct esp32_dmadesc_s *dmadesc; uint8_t *tp; - #ifdef CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP + #ifdef CONFIG_ESP32_SPIRAM uint8_t *alloctp = NULL; #endif - /* If the buffer comes from PSRAM, allocate a new one from DRAM */ + /* If the buffer comes from PSRAM, allocate a new one from SRAM */ Review Comment: DRAM here refers to part of internal SRAM dedicated to Data (similarly as IRAM refers to the Instruction equivalent) If you believe DRAM might be confusing, I suggest to instead mention **Internal SRAM**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org