xiaoxiang781216 commented on code in PR #8985: URL: https://github.com/apache/nuttx/pull/8985#discussion_r1161181477
########## drivers/pipes/pipe_common.h: ########## @@ -135,6 +137,12 @@ struct pipe_dev_s struct pollfd *d_fds[CONFIG_DEV_PIPE_NPOLLWAITERS]; }; +enum pipe_common_type_e +{ + PIPE_COMMON_PIPE = 0, /* Pipe */ + PIPE_COMMON_MKFIFO, /* Named pipe */ Review Comment: Why not add O_NONBLOCK temporarily and remove it if caller doesn't really pass O_NONBLOCK, which make the change more simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org