xiaoxiang781216 commented on code in PR #1698: URL: https://github.com/apache/nuttx-apps/pull/1698#discussion_r1159949781
########## Makefile: ########## @@ -76,7 +77,7 @@ ifeq ($(CONFIG_BUILD_KERNEL),y) install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install) -$(BIN): $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all) +$(BIN): $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_romloader) $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all) Review Comment: No, I mean the user could generate the romfs content in context phase: ``` I don't like it either but it was the only way I found to make sure that the romloader app is compiled after all the required files are generated (and without making it a kconfig dependency). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
