pkarashchenko commented on code in PR #8950: URL: https://github.com/apache/nuttx/pull/8950#discussion_r1159560720
########## drivers/net/telnet.c: ########## @@ -420,25 +415,16 @@ static ssize_t telnet_receive(FAR struct telnet_dev_s *priv, break; case STATE_DO: -#ifdef CONFIG_TELNET_CHARACTER_MODE - if (ch == TELNET_SGA || ch == TELNET_ECHO) + + if (priv->td_lflag & ECHO && ch == TELNET_ECHO) Review Comment: ```suggestion if ((priv->td_lflag & ECHO) && ch == TELNET_ECHO) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org