yamt commented on PR #8868: URL: https://github.com/apache/nuttx/pull/8868#issuecomment-1496884086
> > > > > > > ls /data will report the error. This patch ensures the user get the consistent result regardless he launches the program from anywhere. > > > > > > > > > > > > > > > > > > probably sometimes it's a good thing. in the other cases it can be a bad thing. > > > > > > > > > > > > > > > could you explain more when is it good or bad? I can't understand why it's a bad thing to give the user the consistent result. > > > > > > > > > > > > i usually don't use relative path to mount hostfs. > > > > > > > > > If you want to share the prebuilt nuttx binary or initial script to other people, the related path is better than the absolute path, since the host resource folder mounted by the initial script is normally at the fix location related to nuttx binary. > > > > but when i do, i expect it means relative to the host cwd. > > > > > > > > > From the previous example, you can see the location related to nuttx binary is better than the current directory. > > > > this change introduces a surprising behavior to me. > > > > > > > > > As I explain before, it's the top complaint from our daily report. Since you seldom use the relative path in mount, please trust the data we collected, thanks. > > > > > > what's "our daily report"? > > i can understand some people is not happy with the current behavior. i suspect there can be more people who is happy with the current behavior though. > > with the current behavior, if you want to use a path relative to the executable, you can just set cwd. after this change, it's impossible to use a cwd-relative path. i consider it less flexible. > > > > at least on traditional unix, the path of executable usually doesn't affect the behavior of it. > > > > > > > > > Here is a demo that shared-object search path may relate to the path of executable: https://unix.stackexchange.com/questions/22926/where-do-executables-look-for-shared-objects-at-runtime > > > > > > i'm aware of $ORIGIN stuff. that's why i said "traditional". IMO it's a misfeature. > > Ok, let's stop the discussion which one is better. @Gary-Hobson let's support both. i agree that there seems no single "obvious" behavior. maybe you can support something similar to "$ORIGIN" in the path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
