gustavonihei commented on code in PR #8949:
URL: https://github.com/apache/nuttx/pull/8949#discussion_r1157531709
##########
drivers/video/fb.c:
##########
@@ -674,8 +674,15 @@ static int fb_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
break;
default:
- gerr("ERROR: Unsupported IOCTL command: %d\n", cmd);
- ret = -ENOTTY;
+ if (fb->vtable->ioctl)
Review Comment:
```suggestion
if (fb->vtable->ioctl != NULL)
```
nit: Make the pointer validation more explicit by comparing to `NULL`,
following the pattern from above cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
