Junbo-Zheng commented on code in PR #1700: URL: https://github.com/apache/nuttx-apps/pull/1700#discussion_r1157121311
########## system/zmodem/host/nuttx/config.h: ########## @@ -34,8 +36,6 @@ /* Environment stuff */ -#define OK 0 -#define ERROR -1 Review Comment: > shold we keep this? I guess that PC sys/types.h doesn't define them. Done, thanks correct me, I have reverted the changes, please review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org