xiaoxiang781216 commented on code in PR #8924: URL: https://github.com/apache/nuttx/pull/8924#discussion_r1153470702
########## binfmt/builtin.c: ########## @@ -106,6 +106,8 @@ static int builtin_loadbinary(FAR struct binary_s *binp, binp->entrypt = builtin->main; binp->stacksize = builtin->stacksize; binp->priority = builtin->priority; + binp->proguid = builtin->proguid; + Review Comment: We will definitely follow POSIX spec, for the real file e.g., romfs etc), elf loader checks the file mode and overwrite euid/egid by file's uid/gid if I_SUID/I_SGID is set. For binfs, we will add mode/uid/gid to builtin_s struct, so the builtin loader can overwrite euid/egid like elf loader. Of course, all of this code is guarded by SCHED_USER_IDENTITY. Do you think this change is reanable and compatible with POSIX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
