michallenc commented on issue #8858: URL: https://github.com/apache/nuttx/issues/8858#issuecomment-1484888230
Hi, I've finished the first take of possible adjtime implementation. The [commit can be found here](https://github.com/michallenc/incubator-nuttx/commit/7c0ad06546bec8e07ce23d7fe26c4e7fbbf35d0e). There are few things I would like to discuss before going into PR. 1. Licensing issue: While major part of the implementation is my own and therefore can be released under Apache License, the idea of the algorithm itself is taken from libntp @patacongo refered to. I am not sure about licensing in this case. Do we need the original author agreement? 2. I implemented adjtime function separately from TIMEKEEPING support as that seems to be implementing not only adjtime but also some other stuffs. I think it is ok to keep it separate, what do you think? Other than that, the adjustment seems to be working fine based on the tests I made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
