pkarashchenko opened a new pull request, #8867:
URL: https://github.com/apache/nuttx/pull/8867

   ## Summary
   This PR contains the following changes:
   1. Remove `SIGCONDTIMEDOUT` as I couldn't find any reference to it in the 
code tree.
   2. Add `SIGSYS` signal as it is stated in POSIX 
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html
   3. Refine and optimise `strsignal()` implementation according to 
https://pubs.opengroup.org/onlinepubs/9699919799/functions/strsignal.html
   
   The POSIX states that:
   - `The strsignal() function need not be thread-safe.`
   - `The returned pointer might be invalidated or the string content might be 
overwritten by a subsequent call to strsignal() or setlocale().`
   
   So there is a room for using `snprintf` instead of static strings allocation 
in case of unknown signal value is passed to `strsignal()`
   
   ## Impact
   I do not expect big impact since:
   1. The `SIGCONDTIMEDOUT` was not use
   2.`CONFIG_LIBC_STRSIGNAL` is enabled by default and 
`CONFIG_LIBC_STRSIGNAL_SHORT` is enabled by default only for 
`CONFIG_DEFAULT_SMALL` case.
   
   ## Testing
   Pass CI.
   Tests are in progress.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to