[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8755: ramlog: optimize ramlog_addchar, copy as much content as possible at a time

[via GitHub]

xiaoxiang781216 commented on code in PR #8755:
URL: https://github.com/apache/nuttx/pull/8755#discussion_r1133040505


##########
drivers/syslog/ramlog.c:
##########
@@ -819,7 +787,7 @@ int ramlog_putc(FAR struct syslog_channel_s *channel, int 
ch)
 
   /* Add the character to the RAMLOG */
 
-  ret = ramlog_addchar(priv, ch);
+  ret = ramlog_addbuf(priv, (char *)&ch, 1);

Review Comment:
   use the temp variable instead cast to handle the big endian correctly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org