Cynerd commented on code in PR #8577: URL: https://github.com/apache/nuttx/pull/8577#discussion_r1111551826
########## boards/arm/samv7/common/include/board_hsmci.h: ########## @@ -59,7 +59,7 @@ extern "C" ****************************************************************************/ int sam_hsmci_initialize(int slotno, int minor, gpio_pinset_t cdcfg, - int cdirq); + int cdirq, bool cdinvert); Review Comment: I am ok with that. Honestly, that was my original version and idea. I ended up on this because the original author probably expected support for multiple SD card slots; that was my explanation for passing card detection pin. In such case, the assumption, when using macro, is that everery slot on the board is wired the same way. I do not have nothing against that assumption. I also not see a board with more than one slot in my vicinity. I only implemented it this way to keep it consistent with already established approach of passing card detection configuration. In short, go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
