xiaoxiang781216 commented on code in PR #7525: URL: https://github.com/apache/nuttx/pull/7525#discussion_r1111188324
########## include/nuttx/net/netconfig.h: ########## @@ -318,11 +318,11 @@ /* The maximum amount of concurrent UDP connection, Default: 10 */ -#ifndef CONFIG_NET_UDP_CONNS -# ifdef CONFIG_NET_UDP -# define CONFIG_NET_UDP_CONNS 10 +#ifndef CONFIG_NET_UDP_PREALLOC_CONNS Review Comment: but it's better to move the change here directly. ########## include/nuttx/net/netconfig.h: ########## @@ -451,11 +451,11 @@ * connection requires approximately 30 bytes of memory. */ -#ifndef CONFIG_NET_TCP_CONNS -# ifdef CONFIG_NET_TCP -# define CONFIG_NET_TCP_CONNS 10 +#ifndef CONFIG_NET_TCP_PREALLOC_CONNS Review Comment: but it's better to move the change to the first patch, instead removing in the later patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
