xiaoxiang781216 commented on code in PR #8383:
URL: https://github.com/apache/nuttx/pull/8383#discussion_r1092714339
##########
fs/mqueue/mq_open.c:
##########
@@ -211,10 +214,15 @@ static int file_mq_vopen(FAR struct file *mq, FAR const
char *mq_name,
/* Make sure that the check for the existence of the message queue
* and the creation of the message queue are atomic with respect to
* other processes executing mq_open(). A simple sched_lock() should
- * be sufficient.
+ * be sufficient for non-SMP case but critical section is needed for
+ * SMP case.
*/
+#ifdef CONFIG_SMP
+ flags = enter_critical_section();
+#else
Review Comment:
BTW, I found that some place under fs/ still use sched_lock/sched_unlock,
all should convert to inode_lock/inode_unlock I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
