jlaitine commented on code in PR #8138: URL: https://github.com/apache/nuttx/pull/8138#discussion_r1071201320
########## fs/mmap/fs_rammap.c: ########## @@ -235,7 +237,6 @@ int rammap(FAR struct file *filep, FAR struct mm_map_entry_s *entry, /* Add the buffer to the list of regions */ - entry->vaddr = rdbuffer; entry->priv.i = kernel; entry->munmap = unmap_rammap; Review Comment: The "rdbuffer" pointer is no longer pointing to the original allocated pointer, when gotoed from lines 215, 245. In the "free" below on lines 253, 257 we should use entry->vaddr, since that stores the original allocated ptr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
