XinStellaris commented on code in PR #8067:
URL: https://github.com/apache/nuttx/pull/8067#discussion_r1068882202
##########
net/local/local_fifo.c:
##########
@@ -603,6 +657,17 @@ int local_open_receiver(FAR struct local_conn_s *conn,
bool nonblock)
/* Policy: Free FIFO resources when the buffer is empty. */
ret = local_set_policy(&conn->lc_infile, 1);
+
+ if (ret == 0)
Review Comment:
After a while of reviewing the logic, here is my key thought:
POLLIN/ POLLOUT shouldn't happen if only preamble can be buffered, whether
block or nonblock.
Though only nonblock will lead to a much worse result: packet receiving
failure. I don't think we should distinguish between block and non-block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
