Gary-Hobson commented on code in PR #8012: URL: https://github.com/apache/nuttx/pull/8012#discussion_r1059416771
########## drivers/syslog/vsyslog.c: ########## @@ -128,7 +130,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap) #if defined(CONFIG_SYSLOG_COLOR_OUTPUT) /* Reset the terminal style. */ - ret = lib_sprintf(&stream.public, "\e[0m"); + offset += sprintf(offset, "\e[0m"); Review Comment: lib_sprintf directly calls syslog_putc to output character by character sprintf can save the formatted string to the buffer, and then call syslog_write once to output. It actually reduces the number of calls to syslog_putc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
