xiaoxiang781216 commented on code in PR #8000: URL: https://github.com/apache/nuttx/pull/8000#discussion_r1059375981
########## include/nuttx/fs/fs.h: ########## @@ -206,16 +207,21 @@ struct file_operations * treated like unions. */ - int (*close)(FAR struct file *filep); - ssize_t (*read)(FAR struct file *filep, FAR char *buffer, size_t buflen); - ssize_t (*write)(FAR struct file *filep, FAR const char *buffer, - size_t buflen); - off_t (*seek)(FAR struct file *filep, off_t offset, int whence); - int (*ioctl)(FAR struct file *filep, int cmd, unsigned long arg); + int (*close)(FAR struct file *filep); + ssize_t (*read)(FAR struct file *filep, FAR char *buffer, size_t buflen); + ssize_t (*write)(FAR struct file *filep, FAR const char *buffer, + size_t buflen); + off_t (*seek)(FAR struct file *filep, off_t offset, int whence); + int (*ioctl)(FAR struct file *filep, int cmd, unsigned long arg); + int (*truncate)(FAR struct file *filep, off_t length); + FAR void *(*mmap)(FAR struct file *filep, off_t start, size_t length); + int (*munmap)(FAR struct task_group_s *group, FAR struct inode *inode, Review Comment: block_operations and mtd_dev_s need add the similar callback too. BTW, BCH driver need forward the call from file_operations->block_oerations and FTL need forward block_oerations to mtd_dev_s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org