[GitHub] [nuttx] Gary-Hobson commented on a diff in pull request #7900: drivers/note: move taskname related functions to note_taskname.c

[GitBox]

Gary-Hobson commented on code in PR #7900:
URL: https://github.com/apache/nuttx/pull/7900#discussion_r1055187338


##########
drivers/note/note_driver.c:
##########
@@ -499,8 +596,8 @@ void sched_note_start(FAR struct tcb_s *tcb)
 
           DEBUGASSERT(namelen <= CONFIG_TASK_NAME_SIZE);
           strlcpy(note.nsa_name, tcb->name, sizeof(note.nsa_name));
-
           length = SIZEOF_NOTE_START(namelen + 1);
+          note_record_taskname(tcb->pid, tcb->name);

Review Comment:
   done



##########
drivers/note/note_driver.c:
##########
@@ -1603,6 +1700,13 @@ void sched_note_filter_mode(FAR struct 
note_filter_mode_s *oldm,
       g_note_filter.mode = *newm;
     }
 
+  /* Clear the taskname buffer if note is closed */
+
+  if (!(g_note_filter.mode.flag & NOTE_FILTER_MODE_FLAG_ENABLE))

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org