xiaoxiang781216 commented on code in PR #7933:
URL: https://github.com/apache/nuttx/pull/7933#discussion_r1052814885
##########
arch/arm/src/lpc17xx_40xx/lpc17_40_can.c:
##########
@@ -1049,17 +1062,22 @@ static int lpc17can_txpoll(struct net_driver_s *dev)
if (priv->dev.d_len > 0)
{
- /* Send the packet */
-
- lpc17can_transmit(priv);
+ if (!devif_loopback(&priv->dev))
Review Comment:
devif_loopback is specific for ipv4 and ipv6 protocol, is it good to call it
in can driver?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
