pkarashchenko commented on code in PR #7877:
URL: https://github.com/apache/nuttx/pull/7877#discussion_r1048876992
##########
sched/sched/sched_releasetcb.c:
##########
@@ -126,7 +126,22 @@ int nxsched_release_tcb(FAR struct tcb_s *tcb, uint8_t
ttype)
if (tcb->stack_alloc_ptr)
{
- up_release_stack(tcb, ttype);
+ #ifdef CONFIG_BUILD_KERNEL
+ /* If the exiting thread is not a kernel thread, then it has an
+ * address environment. Don't bother to release the stack memory
+ * in this case... There is no point since the memory lies in the
+ * user memory region that will be destroyed anyway (and the
+ * address environment has probably already been destroyed at
+ * this point.. so we would crash if we even tried it). But if
+ * this is a privileged group, when we still have to release the
+ * memory using the kernel allocator.
+ */
+
+ if (ttype == TCB_FLAG_TTYPE_KERNEL)
+ #endif
Review Comment:
remove leading spaces
##########
sched/sched/sched_releasetcb.c:
##########
@@ -126,7 +126,22 @@ int nxsched_release_tcb(FAR struct tcb_s *tcb, uint8_t
ttype)
if (tcb->stack_alloc_ptr)
{
- up_release_stack(tcb, ttype);
+ #ifdef CONFIG_BUILD_KERNEL
Review Comment:
remove leading spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
