Gary-Hobson commented on code in PR #7841:
URL: https://github.com/apache/nuttx/pull/7841#discussion_r1045868450


##########
drivers/note/sched_note.c:
##########
@@ -409,22 +486,31 @@ static void note_spincommon(FAR struct tcb_s *tcb,
                             int type)
 {
   struct note_spinlock_s note;
+  channel_variable_init;
 
   if (!note_isenabled())
     {
       return;
     }
 
+  note_foreach_channel(g_note_channel_list, channel)

Review Comment:
   In note_foreach_channel, check whether you need to call a custom format 
function and count the number of times you need to call the nuttx default 
format function
   
   In channel_foreach_write, write the data formatted by nuttx to the channel 
with write callback
   
   However, the same channel should not be written twice, fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to