wengzhe commented on code in PR #7826: URL: https://github.com/apache/nuttx/pull/7826#discussion_r1043640696
########## net/ipforward/ipforward.h: ########## @@ -42,6 +42,16 @@ # define CONFIG_NET_IPFORWARD_NSTRUCT 4 #endif +#if CONFIG_IOB_NBUFFERS <= CONFIG_NET_IPFORWARD_NSTRUCT +# error CONFIG_IOB_NBUFFERS <= CONFIG_NET_IPFORWARD_NSTRUCT \ + IP forward may consume all the IOB and break netdev logic. +#endif Review Comment: > If the relevance of the warning is questionable, maybe we should just delete it. Our CI runs with `-Werror`, so if some defconfig purposely defines a set of values (which are valid) that would trigger the warning, then the CI would raise a false positive here. OK, it's not a very important check so I removed it: if it fails, NuttX will not work under best performance but still works well without problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
