pkarashchenko commented on code in PR #7784:
URL: https://github.com/apache/nuttx/pull/7784#discussion_r1039511512


##########
arch/arm/src/s32k3xx/s32k3xx_edma.c:
##########
@@ -154,6 +154,12 @@ struct s32k3xx_edma_s
   struct s32k3xx_dmach_s dmach[S32K3XX_EDMA_NCHANNELS];
 };
 
+#ifdef CONFIG_S32K3XX_DTCM_HEAP
+extern uint8_t DTCM_BASE_ADDR[];
+extern uint8_t DTCM_END_ADDR[];
+#define DTCM_BACKDOOR_OFFSET 0x1000000

Review Comment:
   Oah, yes. I was just expecting `extern`s  to be separate
   ```
   ```



##########
arch/arm/src/s32k3xx/s32k3xx_edma.c:
##########
@@ -154,6 +154,12 @@ struct s32k3xx_edma_s
   struct s32k3xx_dmach_s dmach[S32K3XX_EDMA_NCHANNELS];
 };
 
+#ifdef CONFIG_S32K3XX_DTCM_HEAP
+extern uint8_t DTCM_BASE_ADDR[];
+extern uint8_t DTCM_END_ADDR[];
+#define DTCM_BACKDOOR_OFFSET 0x1000000

Review Comment:
   Oah, yes. I was just expecting `extern`s  to be separate in
   ```
   /****************************************************************************
    * Public Data
    
****************************************************************************/
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to