[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7776: Minor change for video framebuff

[GitBox]

pkarashchenko commented on code in PR #7776:
URL: https://github.com/apache/nuttx/pull/7776#discussion_r1039360580


##########
drivers/video/video_framebuff.c:
##########
@@ -114,40 +95,41 @@ void video_framebuff_uninit(video_framebuff_t *fbuf)
 
 int video_framebuff_realloc_container(video_framebuff_t *fbuf, int sz)
 {
+  int ret = OK;
+
   if (sz > V4L2_REQBUFS_COUNT_MAX)
     {
       return -EINVAL;
     }
 
-  if (fbuf->vbuf_alloced == NULL || fbuf->container_size != sz)
+  if (fbuf->container_size == sz)
     {
-      if (fbuf->container_size != sz)
-        {
-          if (fbuf->vbuf_alloced != NULL)
-            {
-              kmm_free(fbuf->vbuf_alloced);
-            }
+      return OK;
+    }
 
-          fbuf->vbuf_alloced   = NULL;
-          fbuf->container_size = 0;
-        }
+  if (fbuf->vbuf_alloced != NULL)
+    {
+      kmm_free(fbuf->vbuf_alloced);
+      fbuf->vbuf_alloced   = NULL;
+      fbuf->container_size = 0;
+    }
 
-      if (sz > 0)
+  if (sz > 0)
+    {
+      fbuf->vbuf_alloced =
+        (vbuf_container_t *)kmm_zalloc(sizeof(vbuf_container_t) * sz);

Review Comment:
   do we need type cast here?
   also maybe use `kmm_calloc`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org