zouboan commented on code in PR #7572:
URL: https://github.com/apache/nuttx/pull/7572#discussion_r1034767716
##########
tools/Config.mk:
##########
@@ -393,11 +393,18 @@ endef
# ARCHIVE - Same as above, but ensure the archive is
# created from scratch
+ifeq ($(CONFIG_WINDOWS_NATIVE),y)
+define ARCHIVE
+ $(Q) $(RM) $1
+ $(Q) $(AR) $1 $(2)
+endef
+else
define ARCHIVE
@echo "AR (create): ${shell basename $(1)} $(2)"
Review Comment:
> can we change to:
> ```
> @echo "AR(create): $(1) $(2)"
> ```
> to avoid the duplication.
I tried, but failed! the key problem here is echo too many character in
Windows environment, even `@echo "AR (create): $(2)"` give same error by test.
how about remove `@echo "AR (create): ${shell basename $(1)} $(2)"` as well
in Linux to avoid the duplication?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
