xiaoxiang781216 commented on code in PR #7708:
URL: https://github.com/apache/nuttx/pull/7708#discussion_r1033062631
##########
boards/arm/cxd56xx/common/src/cxd56_crashdump.c:
##########
@@ -239,4 +239,5 @@ void board_crashdump(uintptr_t currentsp, void *tcb,
#if defined(CONFIG_CXD56_RESET_ON_CRASH)
board_reset_on_crash();
#endif
Review Comment:
should we change to this?
```suggestion
#else
return;
#endif
```
return is unnecessary when CONFIG_CXD56_RESET_ON_CRASH is defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
