[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7649: libc: Move the common implementation of up_testset to libc/machine

[GitBox]

pkarashchenko commented on code in PR #7649:
URL: https://github.com/apache/incubator-nuttx/pull/7649#discussion_r1029695366


##########
include/nuttx/spinlock.h:
##########
@@ -105,28 +105,7 @@ typedef uint8_t spinlock_t;
  *
  ****************************************************************************/
 
-#if defined(CONFIG_ARCH_HAVE_TESTSET)
 spinlock_t up_testset(volatile FAR spinlock_t *lock);

Review Comment:
   could you please fix a comment near `spin_islocked`? and modify to `/* bool 
spin_islocked(FAR spinlock_t *lock); */`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org