pussuw commented on code in PR #7618:
URL: https://github.com/apache/incubator-nuttx/pull/7618#discussion_r1028040094
##########
mm/mm_gran/mm_granreserve.c:
##########
@@ -54,13 +54,15 @@
* size - The size of the region to be reserved
*
* Returned Value:
- * None
+ * On success, a non-NULL pointer to the allocated memory is returned;
+ * NULL is returned on failure.
*
****************************************************************************/
-void gran_reserve(GRAN_HANDLE handle, uintptr_t start, size_t size)
+FAR void *gran_reserve(GRAN_HANDLE handle, uintptr_t start, size_t size)
{
FAR struct gran_s *priv = (FAR struct gran_s *)handle;
+ FAR void *ret = (FAR void *)start;
Review Comment:
Philosophical argument: what should happen when this is called with size = 0
(like is tested on line 69)?
In my opinion it can just as well succeed. But I can change this to NULL as
well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
