[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1419: apps: getpid should return process id not thread id

[GitBox]

pkarashchenko commented on code in PR #1419:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/1419#discussion_r1023211077


##########
graphics/pdcurs34/nuttx/pdcthread.c:
##########
@@ -179,7 +179,7 @@ FAR struct pdc_context_s * PDC_ctx(void)
 
   /* Get our PID */

Review Comment:
   ```suggestion
      /* Get our TID */
   ```
   



##########
netutils/thttpd/libhttpd.c:
##########
@@ -2137,7 +2137,7 @@ FAR httpd_server *httpd_initialize(FAR httpd_sockaddr *sa)
 
   /* Save the PID of the main thread */

Review Comment:
   ```suggestion
     /* Save the TID of the main thread */
   ```
   



##########
graphics/pdcurs34/nuttx/pdcthread.c:
##########
@@ -264,7 +264,7 @@ void PDC_ctx_free(void)
 
   /* Get a unique hash key from the PID */

Review Comment:
   ```suggestion
     /* Get a unique hash key from the TID */
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org