[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

[GitBox]

xiaoxiang781216 commented on code in PR #7472:
URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1011122056


##########
arch/arm/src/lpc31xx/lpc31_ehci.c:
##########
@@ -5279,7 +5279,6 @@ struct usbhost_connection_s *lpc31_ehci_initialize(int 
controller)
    *  first port is reset (and enabled)."
    */
 
-  memset(&g_asynchead, 0, sizeof(struct lpc31_qh_s));

Review Comment:
   move to new patch



##########
arch/arm/src/lpc31xx/lpc31_ehci.c:
##########
@@ -5303,7 +5302,6 @@ struct usbhost_connection_s *lpc31_ehci_initialize(int 
controller)
    * Head (g_intrhead).
    */
 
-  memset(&g_intrhead, 0, sizeof(struct lpc31_qh_s));

Review Comment:
   move to new patch



##########
arch/arm/src/lpc31xx/lpc31_ehci.c:
##########
@@ -5440,10 +5438,6 @@ struct usbhost_connection_s *lpc31_ehci_initialize(int 
controller)
   up_enable_irq(LPC31_IRQ_USBOTG); /* enable USB interrupt */
   usbhost_vtrace1(EHCI_VTRACE1_INIITIALIZED, 0);
 
-  /* Initialize and return the connection interface */
-
-  g_ehciconn.wait      = lpc31_wait;
-  g_ehciconn.enumerate = lpc31_enumerate;

Review Comment:
   move to new patch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org